Enable mkFit initialStep for track building in phase-2 era, and introduce noMkFit phase-2 era(s) #160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmasciov
force-pushed
the
mkFitPhase2Enable
branch
from
7478fc8 to
1a43bec
Compare
slava77
reviewed
Feb 17, 2025
| from Configuration.Eras.Era_Phase2C10_dd4hep_cff import Phase2C10_dd4hep | ||
| from Configuration.Eras.ModifierChain_trackingMkFitProd_cff import trackingMkFitProdPhase2 | ||
|
|
||
| Phase2C10_dd4hep_noMkFit = cms.ModifierChain(Phase2C10_dd4hep.copyAndExclude([trackingMkFitProdPhase2])) |
There was a problem hiding this comment.
I would've made a noMkFit only for the production detector setup. But I guess it wouldn't really hurt to have more.
Author
There was a problem hiding this comment.
I am aware I probably overdid it, but I thought that overdoing was better than the other way around, to avoid potential objections, as indeed it shouldn't hurt to have more.
slava77
reviewed
Feb 17, 2025
mmasciov
force-pushed
the
mkFitPhase2Enable
branch
from
1a43bec to
8798217
Compare
…duce noMkFit phase-2 era(s)
mmasciov
force-pushed
the
mkFitPhase2Enable
branch
from
8798217 to
2cc100f
Compare
Author
|
To central CMSSW: cms-sw#47383 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description:
As per title, and presented at TRK POG meeting on Feb. 11:
https://indico.cern.ch/event/1498184/#56-mkfit-updates-for-phase-2
PR validation:
As presented at TRK POG meeting on Feb. 11:
https://indico.cern.ch/event/1498184/#56-mkfit-updates-for-phase-2
In short: physics performance is ~ on par with CKF (default), while timing is reduced.
It requires PR cms-data/RecoTracker-MkFit#16 for results shown at TRK POG.